This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (es >= hohid() && cer && dicche() && (ril || !e)) {
...
...
// Pretend there is lots of code here
...
...
} else {
hedme();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (e && !ril || !dicche() || !cer || es <= hohid()) {
hedme();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (i && mape && ducria() && !ot && !em) {
if (!em) {
return true;
}
if (!ot) {
return true;
}
if (ducria()) {
return true;
}
if (mape) {
return true;
}
if (cel <= 1) {
return true;
}
}
return false;
return (cel <= 1 || i) && mape && ducria() && !ot && !em;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!i && cel >= 1) {
if (!mape) {
if (!ducria()) {
if (ot) {
if (em) {
return false;
}
}
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (a == true) {
epac();
} else if (!hou && a != true) {
miness();
} else if (me == false && a != true && hou) {
briVema();
} else if ((io == pism) == true && a != true && hou && me != false) {
elox();
}
if (ilo <= 2 && a != true && hou && me != false && (io == pism) != true) {
doiRhisul();
}
{
if (a) {
epac();
}
if (!hou) {
miness();
}
if (!me) {
briVema();
}
if (io == pism) {
elox();
}
if (ilo <= 2) {
doiRhisul();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: