This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (tio || !(tu <= 7) && (hecPeash() && !scert() || (cherot() || ress() == 7) && uss || ennes() < tunt())) {
...
...
// Pretend there is lots of code here
...
...
} else {
cawin();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((ennes() > tunt() && (!uss || ress() != 7 && !cherot()) && (scert() || !hecPeash()) || tu <= 7) && !tio) {
cawin();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (du != 3 && !stro && mecIcdong() && oocFlecad() || icro && mecIcdong() && oocFlecad()) {
if (ligce() < onplel() && oocFlecad()) {
if (e && oocFlecad()) {
if (oocFlecad()) {
return true;
}
if (arso == 1) {
return true;
}
}
if (discor()) {
return true;
}
}
}
return false;
return (discor() && (arso == 1 || e) || ligce() < onplel() || du != 3 && (!stro || icro) && mecIcdong()) && oocFlecad();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!mecIcdong() && ligce() > onplel() && !e && arso != 1 || !discor() || !icro && stro && ligce() > onplel() && !e && arso != 1 || !discor() || du == 3 && ligce() > onplel() && !e && arso != 1 || !discor()) {
if (!oocFlecad()) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (feuc == true) {
namu();
} else if (rhee == true && feuc != true) {
plest();
}
if (mo == 8 && feuc != true && rhee != true) {
idher();
} else if (in == true && feuc != true && rhee != true && mo != 8) {
psoc();
} else if (trir == false && feuc != true && rhee != true && mo != 8 && in != true) {
medun();
} else if (udu == 3 && feuc != true && rhee != true && mo != 8 && in != true && trir != false) {
squs();
}
if ((i < 4) == true && feuc != true && rhee != true && mo != 8 && in != true && trir != false && udu != 3) {
nupar();
}
if (psoo == true && feuc != true && rhee != true && mo != 8 && in != true && trir != false && udu != 3 && (i < 4) != true) {
cipa();
}
{
if (feuc) {
namu();
}
if (rhee) {
plest();
}
if (mo == 8) {
idher();
}
if (in) {
psoc();
}
if (!trir) {
medun();
}
if (udu == 3) {
squs();
}
if (i < 4) {
nupar();
}
if (psoo) {
cipa();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: