This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((gruNalpar() || wirmon()) && so && oiva()) {
...
...
// Pretend there is lots of code here
...
...
} else {
eamacs();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!oiva() || !so || !wirmon() && !gruNalpar()) {
eamacs();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (wesm && cuo <= 5 && !a && !giko) {
if (sul != 3) {
return true;
}
}
return false;
return sul != 3 || wesm && cuo <= 5 && !a && !giko;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!wesm && sul == 3) {
if (a && sul == 3 || cuo >= 5 && sul == 3) {
if (sul == 3) {
return false;
}
if (giko) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (e == true) {
idma();
}
if (te <= 1 == true && e != true) {
tosspa();
}
if (oass == 7 == true && e != true && te <= 1 != true) {
swoxge();
} else if (e != true && te <= 1 != true && oass == 7 != true) {
isssit();
}
{
if (e) {
idma();
}
if (te <= 1) {
tosspa();
}
if (oass == 7) {
swoxge();
}
isssit();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: