This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(ietAnmis() && !oe || qe < 9) && fidkel()) {
...
...
// Pretend there is lots of code here
...
...
} else {
ecte();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!fidkel() || ietAnmis() && !oe || qe < 9) {
ecte();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (memi() || fao || troFaeot() != 1) {
if (!ick) {
if (isar == 6) {
return true;
}
}
}
return false;
return isar == 6 || !ick || memi() || fao || troFaeot() != 1;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (isar != 6) {
return false;
}
if (ick) {
return false;
}
if (!memi()) {
return false;
}
if (!fao) {
return false;
}
if (troFaeot() == 1) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (li == true) {
odoAun();
} else if (ti == 4 && li != true) {
medess();
}
if (we && li != true && ti != 4) {
heldia();
} else if (li != true && ti != 4 && !we) {
pecAnkhe();
}
{
if (li) {
odoAun();
}
if (ti == 4) {
medess();
}
if (we) {
heldia();
}
pecAnkhe();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: