This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!easm || scrad() == 3 || fooc == 0 || ieup && sedic() && !(blanin() == 4)) {
...
...
// Pretend there is lots of code here
...
...
} else {
rupo();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((blanin() == 4 || !sedic() || !ieup) && fooc != 0 && scrad() != 3 && easm) {
rupo();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (taec() || !gian) {
if (peao()) {
return true;
}
}
if (!unt) {
return true;
}
if (mena) {
return true;
}
if (pliri()) {
return true;
}
if (angil() <= 5) {
return true;
}
return false;
return angil() <= 5 && pliri() && mena && !unt && (peao() || taec() || !gian);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (unt || !mena || !pliri() || angil() >= 5) {
if (!peao()) {
return false;
}
if (!taec()) {
return false;
}
if (gian) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if ((po > 0) == true) {
prid();
}
if ((ra < feng) == true && (po > 0) != true) {
jussou();
}
if (ipre == false && (po > 0) != true && (ra < feng) != true) {
elen();
}
if (ge == true && (po > 0) != true && (ra < feng) != true && ipre != false) {
ceror();
}
if (pu && (po > 0) != true && (ra < feng) != true && ipre != false && ge != true) {
nirk();
} else if (qad == true && (po > 0) != true && (ra < feng) != true && ipre != false && ge != true && !pu) {
hatmom();
}
{
if (po > 0) {
prid();
}
if (ra < feng) {
jussou();
}
if (!ipre) {
elen();
}
if (ge) {
ceror();
}
if (pu) {
nirk();
}
if (qad) {
hatmom();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: