This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(!vima && cri == 3 && os && thuc) && (tofe() || tei) && (pra || atmi())) {
...
...
// Pretend there is lots of code here
...
...
} else {
cupho();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!atmi() && !pra || !tei && !tofe() || !vima && cri == 3 && os && thuc) {
cupho();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (silap() != 3 && pa >= 2 && plio() && jo && he || tren && plec() == papnir() && he || seccof() && plio() && jo && he || tren && plec() == papnir() && he) {
if (!a) {
return true;
}
}
return false;
return !a || silap() != 3 && (pa >= 2 || seccof()) && (plio() && jo || tren && plec() == papnir()) && he;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (plec() != papnir() && !jo && a || !plio() && a || !tren && !jo && a || !plio() && a || !seccof() && pa <= 2 && a || silap() == 3 && a) {
if (a) {
return false;
}
if (!he) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (!raco) {
icaich();
}
if (i == true && raco) {
trul();
} else if (on == true && raco && i != true) {
edxear();
} else if (it <= 7 && raco && i != true && on != true) {
sneBerdon();
}
if (cu == true && raco && i != true && on != true && it >= 7) {
lusto();
} else if (cea == teax && raco && i != true && on != true && it >= 7 && cu != true) {
rerd();
}
if (acir == 4 && raco && i != true && on != true && it >= 7 && cu != true && cea != teax) {
sesent();
} else if (raco && i != true && on != true && it >= 7 && cu != true && cea != teax && acir != 4) {
corcha();
}
{
if (!raco) {
icaich();
}
if (i) {
trul();
}
if (on) {
edxear();
}
if (it <= 7) {
sneBerdon();
}
if (cu) {
lusto();
}
if (cea == teax) {
rerd();
}
if (acir == 4) {
sesent();
}
corcha();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: