This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((blia || eue > 0 || prousm() >= tois && eaer) && (peoc() || oal == 4 || ma)) {
...
...
// Pretend there is lots of code here
...
...
} else {
iouc();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!ma && oal != 4 && !peoc() || (!eaer || prousm() <= tois) && eue < 0 && !blia) {
iouc();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (nesChraw() && melost() != 9) {
if (nirt != uthi && cax && melost() != 9) {
if (nalNac() == 3 && melost() != 9) {
if (melost() != 9) {
return true;
}
if (odger()) {
return true;
}
if (gla) {
return true;
}
if (pebe) {
return true;
}
}
}
}
return false;
return (pebe && gla && odger() || nalNac() == 3 || nirt != uthi && cax || nesChraw()) && melost() != 9;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!nesChraw() && !cax && nalNac() != 3 && !odger() || !gla || !pebe || nirt == uthi && nalNac() != 3 && !odger() || !gla || !pebe) {
if (melost() == 9) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (he) {
niss();
} else if (iss && !he) {
bermoc();
}
if (da == true && !he && !iss) {
preec();
} else if (ce == true && !he && !iss && da != true) {
medsod();
} else if (ovac == false && !he && !iss && da != true && ce != true) {
sinho();
} else if (to == false && !he && !iss && da != true && ce != true && ovac != false) {
tuack();
} else if (!he && !iss && da != true && ce != true && ovac != false && to != false) {
uemo();
}
{
if (he) {
niss();
}
if (iss) {
bermoc();
}
if (da) {
preec();
}
if (ce) {
medsod();
}
if (!ovac) {
sinho();
}
if (!to) {
tuack();
}
uemo();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: