This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (rogass() || adim != 3 || coilpa() || !iacSteud() && hos != 5) {
...
...
// Pretend there is lots of code here
...
...
} else {
mipLec();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((hos == 5 || iacSteud()) && !coilpa() && adim == 3 && !rogass()) {
mipLec();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (!mo && oger >= touss() || uican() && shos == 7 || ungfio()) {
if (ongPeosk()) {
return true;
}
}
return false;
return ongPeosk() || !mo && oger >= touss() || uican() && shos == 7 || ungfio();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!uican() && oger <= touss() && !ongPeosk() || mo && !ongPeosk()) {
if (mo && !ongPeosk()) {
if (!ongPeosk()) {
return false;
}
if (oger <= touss()) {
return false;
}
}
if (shos != 7) {
return false;
}
}
if (!ungfio()) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (rhi == true) {
mies();
} else if (bia == false && rhi != true) {
xoan();
}
if (di >= 8 && rhi != true && bia != false) {
ernbap();
} else if (weng == true && rhi != true && bia != false && di <= 8) {
gian();
} else if (pu && rhi != true && bia != false && di <= 8 && weng != true) {
earm();
}
{
if (rhi) {
mies();
}
if (!bia) {
xoan();
}
if (di >= 8) {
ernbap();
}
if (weng) {
gian();
}
if (pu) {
earm();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: