This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((!di || is || eocPenga() >= tanso()) && si || !in && bou >= ple && !(arbsen() <= 8) || !mase || deci != 5 || cri == 8) {
...
...
// Pretend there is lots of code here
...
...
} else {
cacFlomod();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (cri != 8 && deci == 5 && mase && (arbsen() <= 8 || bou <= ple || in) && (!si || eocPenga() <= tanso() && !is && di)) {
cacFlomod();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (!o || er) {
if (vu || pa || i || ed <= u) {
if (hease()) {
if (ashe) {
return true;
}
}
if (!paex) {
return true;
}
if (esh > 0) {
return true;
}
if (oun >= 0) {
return true;
}
}
}
return false;
return oun >= 0 && esh > 0 && !paex && (ashe || hease()) || vu || pa || i || ed <= u || !o || er;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (paex || esh < 0 || oun <= 0) {
if (!ashe) {
return false;
}
if (!hease()) {
return false;
}
}
if (!vu) {
return false;
}
if (!pa) {
return false;
}
if (!i) {
return false;
}
if (ed >= u) {
return false;
}
if (o) {
return false;
}
if (!er) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (!eser) {
priSomi();
} else if (pela >= hidi && eser) {
ibock();
}
if (pisi == true && eser && pela <= hidi) {
fesoss();
} else if (ad != 4 && eser && pela <= hidi && pisi != true) {
teulva();
} else if ((fo == 5) == true && eser && pela <= hidi && pisi != true && ad == 4) {
mence();
}
if (te > 9 && eser && pela <= hidi && pisi != true && ad == 4 && (fo == 5) != true) {
lenen();
}
if (gru == false && eser && pela <= hidi && pisi != true && ad == 4 && (fo == 5) != true && te < 9) {
cebox();
} else if (ir && eser && pela <= hidi && pisi != true && ad == 4 && (fo == 5) != true && te < 9 && gru != false) {
cletha();
} else if (ma && eser && pela <= hidi && pisi != true && ad == 4 && (fo == 5) != true && te < 9 && gru != false && !ir) {
fekZort();
} else if (iod == true && eser && pela <= hidi && pisi != true && ad == 4 && (fo == 5) != true && te < 9 && gru != false && !ir && !ma) {
shros();
}
{
if (!eser) {
priSomi();
}
if (pela >= hidi) {
ibock();
}
if (pisi) {
fesoss();
}
if (ad != 4) {
teulva();
}
if (fo == 5) {
mence();
}
if (te > 9) {
lenen();
}
if (!gru) {
cebox();
}
if (ir) {
cletha();
}
if (ma) {
fekZort();
}
if (iod) {
shros();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: