This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((!(miava() && igi >= fe) || me || cotpo() || rir) && ucle() != 8 || sua && u == 1 && !alta || fapPioc()) {
...
...
// Pretend there is lots of code here
...
...
} else {
podo();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!fapPioc() && (alta || u != 1 || !sua) && (ucle() == 8 || !rir && !cotpo() && !me && miava() && igi >= fe)) {
podo();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (!ba && !er && cooc || tipia() < diddan() && el) {
if (ro || ema) {
if (cabial()) {
if (inio()) {
return true;
}
}
if (noce) {
return true;
}
}
if (esh) {
return true;
}
}
return false;
return esh && (noce && (inio() || cabial()) || ro || ema) || !ba && !er && cooc || tipia() < diddan() && el;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (tipia() > diddan() && !cooc && !ema && !ro && !cabial() && !inio() || !noce || !esh || er && !ema && !ro && !cabial() && !inio() || !noce || !esh || ba && !ema && !ro && !cabial() && !inio() || !noce || !esh) {
if (ba && !ema && !ro && !cabial() && !inio() || !noce || !esh) {
if (er && !ema && !ro && !cabial() && !inio() || !noce || !esh) {
if (!esh) {
if (!noce) {
if (!inio()) {
return false;
}
if (!cabial()) {
return false;
}
}
if (!ro) {
return false;
}
if (!ema) {
return false;
}
}
if (!cooc) {
return false;
}
}
}
if (!el) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (es == true) {
didor();
} else if (sape == true && es != true) {
aeoo();
} else if (a == true && es != true && sape != true) {
uliCrai();
}
if (ir == false && es != true && sape != true && a != true) {
truShaiz();
}
if (al != na && es != true && sape != true && a != true && ir != false) {
onphos();
} else if (e == true && es != true && sape != true && a != true && ir != false && al == na) {
ught();
}
if (oned == false && es != true && sape != true && a != true && ir != false && al == na && e != true) {
troto();
}
if (in == true && es != true && sape != true && a != true && ir != false && al == na && e != true && oned != false) {
teell();
}
if (hu == true && es != true && sape != true && a != true && ir != false && al == na && e != true && oned != false && in != true) {
eueMirrwi();
} else if (es != true && sape != true && a != true && ir != false && al == na && e != true && oned != false && in != true && hu != true) {
laism();
}
{
if (es) {
didor();
}
if (sape) {
aeoo();
}
if (a) {
uliCrai();
}
if (!ir) {
truShaiz();
}
if (al != na) {
onphos();
}
if (e) {
ught();
}
if (!oned) {
troto();
}
if (in) {
teell();
}
if (hu) {
eueMirrwi();
}
laism();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: