This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!ior || ranass() != e || ne || huar()) {
...
...
// Pretend there is lots of code here
...
...
} else {
alno();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!huar() && !ne && ranass() == e && ior) {
alno();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (iast) {
if (iss) {
if (er) {
return true;
}
}
}
if (icad) {
return true;
}
if (lonvi()) {
return true;
}
return false;
return lonvi() && icad && (er || iss || iast);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!icad || !lonvi()) {
if (!er) {
return false;
}
if (!iss) {
return false;
}
if (!iast) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (ress) {
eccect();
} else if (pri == true && !ress) {
ordpom();
}
if (pi >= fai && !ress && pri != true) {
volson();
}
if (har != fe && !ress && pri != true && pi <= fai) {
plall();
}
{
if (ress) {
eccect();
}
if (pri) {
ordpom();
}
if (pi >= fai) {
volson();
}
if (har != fe) {
plall();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: