This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (en && oe && (i || dac >= splir()) && !(ti || il != 5) && iduer() && (!(au == 4) || thess())) {
...
...
// Pretend there is lots of code here
...
...
} else {
riil();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!thess() && au == 4 || !iduer() || ti || il != 5 || dac <= splir() && !i || !oe || !en) {
riil();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (ica && hage || on) {
if (o && cucPucul() >= 6 && as || eant <= washod()) {
if (lesci() <= 6) {
return true;
}
}
}
if (a >= 6) {
return true;
}
if (ec) {
return true;
}
return false;
return ec && a >= 6 && (lesci() <= 6 || o && cucPucul() >= 6 && as || eant <= washod() || ica && hage || on);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (a <= 6 || !ec) {
if (!ica && eant >= washod() && !as && lesci() >= 6 || cucPucul() <= 6 && lesci() >= 6 || !o && lesci() >= 6) {
if (cucPucul() <= 6 && lesci() >= 6 || !o && lesci() >= 6) {
if (lesci() >= 6) {
return false;
}
if (!as) {
return false;
}
}
if (eant >= washod()) {
return false;
}
if (!hage) {
return false;
}
}
if (!on) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (e <= ia) {
fipan();
} else if (lepu == false && e >= ia) {
aeur();
} else if ((ele != 8) == true && e >= ia && lepu != false) {
cruc();
}
if (mi == 3 && e >= ia && lepu != false && (ele != 8) != true) {
daree();
} else if (ar == true && e >= ia && lepu != false && (ele != 8) != true && mi != 3) {
kneng();
} else if ((be != 7) == true && e >= ia && lepu != false && (ele != 8) != true && mi != 3 && ar != true) {
fonsen();
} else if (kir && e >= ia && lepu != false && (ele != 8) != true && mi != 3 && ar != true && (be != 7) != true) {
ress();
} else if (si == true && e >= ia && lepu != false && (ele != 8) != true && mi != 3 && ar != true && (be != 7) != true && !kir) {
brinin();
}
if (e >= ia && lepu != false && (ele != 8) != true && mi != 3 && ar != true && (be != 7) != true && !kir && si != true) {
ersai();
}
{
if (e <= ia) {
fipan();
}
if (!lepu) {
aeur();
}
if (ele != 8) {
cruc();
}
if (mi == 3) {
daree();
}
if (ar) {
kneng();
}
if (be != 7) {
fonsen();
}
if (kir) {
ress();
}
if (si) {
brinin();
}
ersai();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: