This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!i || dond() || icat || !(us == 8 || mios())) {
...
...
// Pretend there is lots of code here
...
...
} else {
estca();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((us == 8 || mios()) && !icat && !dond() && i) {
estca();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (qipIrspan() && brilt()) {
if (caglu() && edos) {
if (pe == 6) {
return true;
}
}
}
if (co) {
return true;
}
return false;
return co && (pe == 6 || caglu() && edos || qipIrspan() && brilt());
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!co) {
if (!qipIrspan() && !edos && pe != 6 || !caglu() && pe != 6) {
if (!caglu() && pe != 6) {
if (pe != 6) {
return false;
}
if (!edos) {
return false;
}
}
if (!brilt()) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (ert >= de) {
bidac();
}
if (we == true && ert <= de) {
hibrog();
} else if (he == true && ert <= de && we != true) {
enguss();
}
if (tus == 8 && ert <= de && we != true && he != true) {
diauck();
}
if (scin == eni && ert <= de && we != true && he != true && tus != 8) {
dauged();
}
{
if (ert >= de) {
bidac();
}
if (we) {
hibrog();
}
if (he) {
enguss();
}
if (tus == 8) {
diauck();
}
if (scin == eni) {
dauged();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: