This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((cret && !(ior != sost()) && nidant() == flia() && !i || canbo() != sema && pi || du) && (id || !(nass() >= caa))) {
...
...
// Pretend there is lots of code here
...
...
} else {
wrair();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (nass() >= caa && !id || !du && (!pi || canbo() == sema) && (i || nidant() != flia() || ior != sost() || !cret)) {
wrair();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (nopche() && esbind() && !ent || trou() && !ent || rocha() && esbind() && !ent || trou() && !ent) {
if (nimse() > isic()) {
if (resor() && odpa) {
if (rup) {
return true;
}
}
}
if (go) {
return true;
}
}
return false;
return go && (rup || resor() && odpa || nimse() > isic()) || (nopche() || rocha()) && (esbind() || trou()) && !ent;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!rocha() && !nopche() && nimse() < isic() && !odpa && !rup || !resor() && !rup || !go) {
if (!trou() && !esbind() && nimse() < isic() && !odpa && !rup || !resor() && !rup || !go) {
if (!go) {
if (!resor() && !rup) {
if (!rup) {
return false;
}
if (!odpa) {
return false;
}
}
if (nimse() < isic()) {
return false;
}
}
if (ent) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (!ji) {
chelte();
}
if (hi >= 5 && ji) {
tocass();
}
if (he == true && ji && hi <= 5) {
hipren();
} else if (oson == 0 && ji && hi <= 5 && he != true) {
phalod();
}
if (so == true && ji && hi <= 5 && he != true && oson != 0) {
cesRidje();
}
if (ruor == true && ji && hi <= 5 && he != true && oson != 0 && so != true) {
asnin();
}
if (o == true && ji && hi <= 5 && he != true && oson != 0 && so != true && ruor != true) {
sesIth();
} else if (dect == false && ji && hi <= 5 && he != true && oson != 0 && so != true && ruor != true && o != true) {
midint();
}
if (prid == true && ji && hi <= 5 && he != true && oson != 0 && so != true && ruor != true && o != true && dect != false) {
apul();
}
{
if (!ji) {
chelte();
}
if (hi >= 5) {
tocass();
}
if (he) {
hipren();
}
if (oson == 0) {
phalod();
}
if (so) {
cesRidje();
}
if (ruor) {
asnin();
}
if (o) {
sesIth();
}
if (!dect) {
midint();
}
if (prid) {
apul();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: