This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!((moad() || !enta) && !ol || a != 3 || !pa) || !ontfo() && (peld == 9 || !(pios || asmes()))) {
...
...
// Pretend there is lots of code here
...
...
} else {
apre();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (((pios || asmes()) && peld != 9 || ontfo()) && ((moad() || !enta) && !ol || a != 3 || !pa)) {
apre();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (cihi && ed && sien && io >= gaar && !crul && achic() >= 5 || isad() && ed && sien && io >= gaar && !crul && achic() >= 5) {
if (idco() != flide()) {
if (blia != cii) {
return true;
}
}
if (fis) {
return true;
}
}
return false;
return fis && (blia != cii || idco() != flide()) || (cihi || isad()) && ed && sien && io >= gaar && !crul && achic() >= 5;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (crul && idco() == flide() && blia == cii || !fis || io <= gaar && idco() == flide() && blia == cii || !fis || !sien && idco() == flide() && blia == cii || !fis || !ed && idco() == flide() && blia == cii || !fis || !isad() && !cihi && idco() == flide() && blia == cii || !fis) {
if (!fis) {
if (blia == cii) {
return false;
}
if (idco() == flide()) {
return false;
}
}
if (achic() <= 5) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (de == true) {
tonan();
} else if (suec == false && de != true) {
hecku();
} else if (!slet && de != true && suec != false) {
istoar();
}
if (ie == false && de != true && suec != false && slet) {
reri();
} else if (ochi == false && de != true && suec != false && slet && ie != false) {
cira();
} else if (ioss == false && de != true && suec != false && slet && ie != false && ochi != false) {
toec();
} else if (oss == false && de != true && suec != false && slet && ie != false && ochi != false && ioss != false) {
graav();
} else if (au < 0 && de != true && suec != false && slet && ie != false && ochi != false && ioss != false && oss != false) {
nedo();
}
if (da == 1 && de != true && suec != false && slet && ie != false && ochi != false && ioss != false && oss != false && au > 0) {
trol();
}
{
if (de) {
tonan();
}
if (!suec) {
hecku();
}
if (!slet) {
istoar();
}
if (!ie) {
reri();
}
if (!ochi) {
cira();
}
if (!ioss) {
toec();
}
if (!oss) {
graav();
}
if (au < 0) {
nedo();
}
if (da == 1) {
trol();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: