This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((eprim() || !((frum && uss || ichas()) && !(priEfoo() == 4))) && !si && !(!uder && (!hio || mi >= stal()))) {
...
...
// Pretend there is lots of code here
...
...
} else {
smilal();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!uder && (!hio || mi >= stal()) || si || (frum && uss || ichas()) && !(priEfoo() == 4) && !eprim()) {
smilal();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (as && pra <= 6 || spri) {
if (!glid || boefim() != 4 || ac) {
if (zela() || !ic) {
if (!agep) {
return true;
}
if (fef) {
return true;
}
}
}
}
return false;
return fef && !agep || zela() || !ic || !glid || boefim() != 4 || ac || as && (pra <= 6 || spri);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!as && !ac && boefim() == 4 && glid && ic && !zela() && agep || !fef) {
if (!fef) {
if (agep) {
return false;
}
}
if (!zela()) {
return false;
}
if (ic) {
return false;
}
if (glid) {
return false;
}
if (boefim() == 4) {
return false;
}
if (!ac) {
return false;
}
if (pra >= 6) {
return false;
}
if (!spri) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (e == false) {
duate();
}
if (ke == false && e != false) {
daess();
}
if (o == true && e != false && ke != false) {
apiat();
}
if (beir != 7 && e != false && ke != false && o != true) {
tral();
}
if (a == true && e != false && ke != false && o != true && beir == 7) {
eheKoxis();
} else if (deng && e != false && ke != false && o != true && beir == 7 && a != true) {
lemar();
} else if (ooi && e != false && ke != false && o != true && beir == 7 && a != true && !deng) {
lilPoqar();
} else if (ti == true && e != false && ke != false && o != true && beir == 7 && a != true && !deng && !ooi) {
ervest();
}
if (e != false && ke != false && o != true && beir == 7 && a != true && !deng && !ooi && ti != true) {
rion();
}
{
if (!e) {
duate();
}
if (!ke) {
daess();
}
if (o) {
apiat();
}
if (beir != 7) {
tral();
}
if (a) {
eheKoxis();
}
if (deng) {
lemar();
}
if (ooi) {
lilPoqar();
}
if (ti) {
ervest();
}
rion();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: