This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (unsu || irfosh() || jii || uloTre() || voubo() == poam || ko < 6 || o || !(giss != 7) || !ceck || shar()) {
...
...
// Pretend there is lots of code here
...
...
} else {
desh();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!shar() && ceck && giss != 7 && !o && ko > 6 && voubo() != poam && !uloTre() && !jii && !irfosh() && !unsu) {
desh();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (ce && esh && kacgin() && erche() && lo && oujer() || umac() && si || pe || pibru() && oujer() || umac() && si || pe) {
if (pibru() && oujer() || umac() && si || pe) {
if (umac() && si || pe) {
if (oujer()) {
return true;
}
}
if (lo) {
return true;
}
if (erche()) {
return true;
}
if (kacgin()) {
return true;
}
if (esh) {
return true;
}
}
if (kewa()) {
return true;
}
}
return false;
return (kewa() || ce) && (esh && kacgin() && erche() && lo || pibru()) && (oujer() || umac() && si || pe);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!pibru() && !lo || !erche() || !kacgin() || !esh || !ce && !kewa()) {
if (!umac() && !oujer()) {
if (!oujer()) {
return false;
}
if (!si) {
return false;
}
}
if (!pe) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (as == true) {
qicCac();
}
if (irlo == 9 && as != true) {
pecVeu();
} else if (akni == true && as != true && irlo != 9) {
andtoe();
}
if (te == false && as != true && irlo != 9 && akni != true) {
sornia();
} else if (!vu && as != true && irlo != 9 && akni != true && te != false) {
hilbep();
} else if (nang == false && as != true && irlo != 9 && akni != true && te != false && vu) {
itwof();
} else if (maic == true && as != true && irlo != 9 && akni != true && te != false && vu && nang != false) {
esmOuss();
}
if (elde && as != true && irlo != 9 && akni != true && te != false && vu && nang != false && maic != true) {
selte();
}
if (is && as != true && irlo != 9 && akni != true && te != false && vu && nang != false && maic != true && !elde) {
flom();
} else if (as != true && irlo != 9 && akni != true && te != false && vu && nang != false && maic != true && !elde && !is) {
rooin();
}
{
if (as) {
qicCac();
}
if (irlo == 9) {
pecVeu();
}
if (akni) {
andtoe();
}
if (!te) {
sornia();
}
if (!vu) {
hilbep();
}
if (!nang) {
itwof();
}
if (maic) {
esmOuss();
}
if (elde) {
selte();
}
if (is) {
flom();
}
rooin();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: