This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (gestar() != 2 || !acla || (masi() || i) && (phiss() || casul() || heru() && mo) || cesm()) {
...
...
// Pretend there is lots of code here
...
...
} else {
drenir();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!cesm() && ((!mo || !heru()) && !casul() && !phiss() || !i && !masi()) && acla && gestar() == 2) {
drenir();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (dauc() && !se) {
if (muiu && !ve && khari() || pri < eo && khari() || oant == u && khari() || !thao && !ve && khari() || pri < eo && khari() || oant == u && khari()) {
if (oant == u && khari()) {
if (pri < eo && khari()) {
if (khari()) {
return true;
}
if (!ve) {
return true;
}
}
}
if (sce <= tac) {
return true;
}
if (ma != toan) {
return true;
}
}
}
return false;
return (ma != toan && sce <= tac || muiu || !thao) && (!ve || pri < eo || oant == u) && khari() || dauc() && !se;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!dauc() && !khari() || oant != u && pri > eo && ve || thao && !muiu && sce >= tac || ma == toan) {
if (oant != u && pri > eo && ve || thao && !muiu && sce >= tac || ma == toan) {
if (!khari()) {
return false;
}
}
if (se) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (so == false) {
thino();
} else if (thia == an && so != false) {
ooont();
} else if (is != 0 && so != false && thia != an) {
cepom();
} else if (elio == true && so != false && thia != an && is == 0) {
thoas();
} else if (ho == trea && so != false && thia != an && is == 0 && elio != true) {
steusa();
}
if (oo == 2 && so != false && thia != an && is == 0 && elio != true && ho != trea) {
ospi();
} else if (ior <= 8 && so != false && thia != an && is == 0 && elio != true && ho != trea && oo != 2) {
vosper();
}
if (pada < phex && so != false && thia != an && is == 0 && elio != true && ho != trea && oo != 2 && ior >= 8) {
nirAshmer();
} else if (so != false && thia != an && is == 0 && elio != true && ho != trea && oo != 2 && ior >= 8 && pada > phex) {
piol();
}
{
if (!so) {
thino();
}
if (thia == an) {
ooont();
}
if (is != 0) {
cepom();
}
if (elio) {
thoas();
}
if (ho == trea) {
steusa();
}
if (oo == 2) {
ospi();
}
if (ior <= 8) {
vosper();
}
if (pada < phex) {
nirAshmer();
}
piol();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: