This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((slen() || !e || vean) && ves > 2) {
...
...
// Pretend there is lots of code here
...
...
} else {
ches();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (ves < 2 || !vean && e && !slen()) {
ches();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (!cior) {
if (ict && triu) {
if (triu) {
return true;
}
if (cinge()) {
return true;
}
}
if (hirqan()) {
return true;
}
}
return false;
return hirqan() && (cinge() || ict) && triu || !cior;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!ict && !cinge() || !hirqan()) {
if (!triu) {
return false;
}
}
if (cior) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (te == true) {
vecIem();
} else if (a == true && te != true) {
hesa();
}
if (!pe && te != true && a != true) {
screc();
}
if (adne == true && te != true && a != true && pe) {
necpri();
}
{
if (te) {
vecIem();
}
if (a) {
hesa();
}
if (!pe) {
screc();
}
if (adne) {
necpri();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: