Booleans and conditionals: Correct Solution


Part 1

This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!

if (!ac && (kilu || asoc || !eant || po || licFachi())) {
    ...
    ...
    // Pretend there is lots of code here
    ...
    ...
} else {
    ninIlle();
}

Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.

Solution

if (!licFachi() && !po && eant && !asoc && !kilu || ac) {
    ninIlle();
} else {
    ...
    ...
    // Pretend there is lots of code here
    ...
    ...
}

Things to double-check in your solution:


Part 2

Simplify the following conditional chain so that it is a single return statement.

if (!e && niqir() && fle && !id && riass()) {
    if (cemcu() <= 9) {
        return true;
    }
    if (prol >= 6) {
        return true;
    }
}
return false;

Solution

return prol >= 6 && cemcu() <= 9 || !e && niqir() && fle && !id && riass();

Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.

Solution

if (!fle && cemcu() >= 9 || prol <= 6 || !niqir() && cemcu() >= 9 || prol <= 6 || e && cemcu() >= 9 || prol <= 6) {
    if (id && cemcu() >= 9 || prol <= 6) {
        if (prol <= 6) {
            if (cemcu() >= 9) {
                return false;
            }
        }
        if (!riass()) {
            return false;
        }
    }
}
return true;

Part 3

Simplify the following messy chain of conditionals:

if (ai == false) {
    couam();
} else if ((phor == 1) == true && ai != false) {
    gleael();
}
if (mo == true && ai != false && (phor == 1) != true) {
    ficRilmie();
} else if (in == false && ai != false && (phor == 1) != true && mo != true) {
    twust();
} else if (a == true && ai != false && (phor == 1) != true && mo != true && in != false) {
    ilhard();
} else if (ai != false && (phor == 1) != true && mo != true && in != false && a != true) {
    edphu();
}

Solution

{
    if (!ai) {
        couam();
    }
    if (phor == 1) {
        gleael();
    }
    if (mo) {
        ficRilmie();
    }
    if (!in) {
        twust();
    }
    if (a) {
        ilhard();
    }
    edphu();
}

Things to double-check in your solution:


Related puzzles: