This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!ir && madto() && e >= esspis() && (redsli() || id) && eosm && me) {
...
...
// Pretend there is lots of code here
...
...
} else {
alcai();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!me || !eosm || !id && !redsli() || e <= esspis() || !madto() || ir) {
alcai();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (qes || ouhu < 4 || sadbe() || thiu || i) {
if (oung != 7) {
if (phie()) {
return true;
}
if (fe) {
return true;
}
}
}
return false;
return fe && phie() || oung != 7 || qes || ouhu < 4 || sadbe() || thiu || i;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!fe) {
if (!phie()) {
return false;
}
}
if (oung == 7) {
return false;
}
if (!qes) {
return false;
}
if (ouhu > 4) {
return false;
}
if (!sadbe()) {
return false;
}
if (!thiu) {
return false;
}
if (!i) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (eas <= so) {
closs();
}
if (he && eas >= so) {
fogtri();
} else if (ae == true && eas >= so && !he) {
birRipse();
} else if ((er >= 9) == true && eas >= so && !he && ae != true) {
eniWakre();
} else if ((fous >= 2) == true && eas >= so && !he && ae != true && (er >= 9) != true) {
fredpi();
}
if (io == true && eas >= so && !he && ae != true && (er >= 9) != true && (fous >= 2) != true) {
pirb();
}
if (cooc != 9 && eas >= so && !he && ae != true && (er >= 9) != true && (fous >= 2) != true && io != true) {
slill();
}
{
if (eas <= so) {
closs();
}
if (he) {
fogtri();
}
if (ae) {
birRipse();
}
if (er >= 9) {
eniWakre();
}
if (fous >= 2) {
fredpi();
}
if (io) {
pirb();
}
if (cooc != 9) {
slill();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: