This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(toofos() == 3) || (cale || !(ema == 8)) && pra != mic && (!sko || rhan() > 9)) {
...
...
// Pretend there is lots of code here
...
...
} else {
tring();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((rhan() < 9 && sko || pra == mic || ema == 8 && !cale) && toofos() == 3) {
tring();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (!es || elaut()) {
if (i <= ma && poc || enma() || wi > 5) {
if (wi > 5) {
if (enma()) {
if (poc) {
return true;
}
}
}
if (spoPhemur()) {
return true;
}
}
}
return false;
return (spoPhemur() || i <= ma) && (poc || enma() || wi > 5) || !es || elaut();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (i >= ma && !spoPhemur()) {
if (!poc) {
return false;
}
if (!enma()) {
return false;
}
if (wi < 5) {
return false;
}
}
if (es) {
return false;
}
if (!elaut()) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (pid == true) {
sanvi();
} else if (peo == true && pid != true) {
gost();
}
if (li == true && pid != true && peo != true) {
aliGred();
} else if (io == true && pid != true && peo != true && li != true) {
roce();
} else if (in == true && pid != true && peo != true && li != true && io != true) {
allnor();
}
if (so == true && pid != true && peo != true && li != true && io != true && in != true) {
grel();
}
{
if (pid) {
sanvi();
}
if (peo) {
gost();
}
if (li) {
aliGred();
}
if (io) {
roce();
}
if (in) {
allnor();
}
if (so) {
grel();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: