This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((!(!ic || feou) || laer()) && (!(osa <= ma) || islo() == 5 || muim() >= scac || mo) && (!nu || ga || a || icni)) {
...
...
// Pretend there is lots of code here
...
...
} else {
oseess();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!icni && !a && !ga && nu || !mo && muim() <= scac && islo() != 5 && osa <= ma || !laer() && (!ic || feou)) {
oseess();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (wa != spap && cipe && selo() && hi || crilin() || kass || edria()) {
if (iemSmoam() && cipe && selo() && hi || crilin() || kass || edria() || dua && !no && cipe && selo() && hi || crilin() || kass || edria()) {
if (kass || edria()) {
if (crilin()) {
if (hi) {
return true;
}
if (selo()) {
return true;
}
}
if (cipe) {
return true;
}
}
if (hess() <= 2) {
return true;
}
}
}
if (iass()) {
return true;
}
return false;
return iass() && (hess() <= 2 || iemSmoam() || dua && !no || wa != spap) && (cipe && (selo() && hi || crilin()) || kass || edria());
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (wa == spap && no && !iemSmoam() && hess() >= 2 || !dua && !iemSmoam() && hess() >= 2 || !iass()) {
if (!cipe) {
if (!selo()) {
if (!hi) {
return false;
}
}
if (!crilin()) {
return false;
}
}
if (!kass) {
return false;
}
if (!edria()) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (pe == true) {
psed();
} else if (huc == false && pe != true) {
hepso();
} else if (vae == true && pe != true && huc != false) {
ussve();
} else if (fa == piol && pe != true && huc != false && vae != true) {
bolcun();
} else if (er == false && pe != true && huc != false && vae != true && fa != piol) {
pecfaw();
} else if (uenk == false && pe != true && huc != false && vae != true && fa != piol && er != false) {
adce();
}
if (pa < 6 && pe != true && huc != false && vae != true && fa != piol && er != false && uenk != false) {
propra();
}
if (nau && pe != true && huc != false && vae != true && fa != piol && er != false && uenk != false && pa > 6) {
feaHisi();
}
if (sifu != aspi && pe != true && huc != false && vae != true && fa != piol && er != false && uenk != false && pa > 6 && !nau) {
casTegal();
} else if (fre && pe != true && huc != false && vae != true && fa != piol && er != false && uenk != false && pa > 6 && !nau && sifu == aspi) {
restam();
} else if (pe != true && huc != false && vae != true && fa != piol && er != false && uenk != false && pa > 6 && !nau && sifu == aspi && !fre) {
piri();
}
{
if (pe) {
psed();
}
if (!huc) {
hepso();
}
if (vae) {
ussve();
}
if (fa == piol) {
bolcun();
}
if (!er) {
pecfaw();
}
if (!uenk) {
adce();
}
if (pa < 6) {
propra();
}
if (nau) {
feaHisi();
}
if (sifu != aspi) {
casTegal();
}
if (fre) {
restam();
}
piri();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: