This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (be || !sqa || isris() && (snof || ar) || !rerFewhed()) {
...
...
// Pretend there is lots of code here
...
...
} else {
ralas();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (rerFewhed() && (!ar && !snof || !isris()) && sqa && !be) {
ralas();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (acclad() != 5 && idild() > 7 && dabu() || pidesh() > ond) {
if (pidesh() > ond) {
if (dabu()) {
return true;
}
}
if (idild() > 7) {
return true;
}
if (ie) {
return true;
}
if (liu < 7) {
return true;
}
}
if (unt) {
return true;
}
return false;
return unt && (liu < 7 && ie || acclad() != 5) && idild() > 7 && (dabu() || pidesh() > ond);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (idild() < 7 || acclad() == 5 && !ie || liu > 7 || !unt) {
if (!dabu()) {
return false;
}
if (pidesh() < ond) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (i) {
hird();
} else if (hi != cio && !i) {
rirk();
} else if (in == true && !i && hi == cio) {
peouar();
}
if (es == false && !i && hi == cio && in != true) {
snuid();
}
if (ci == revi && !i && hi == cio && in != true && es != false) {
sple();
}
if (!i && hi == cio && in != true && es != false && ci != revi) {
doti();
}
{
if (i) {
hird();
}
if (hi != cio) {
rirk();
}
if (in) {
peouar();
}
if (!es) {
snuid();
}
if (ci == revi) {
sple();
}
doti();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: