This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (prudec() && !fi || (natra() && enca() >= 0 || racShong() > ube) && caed && zect && i <= 8 && onep) {
...
...
// Pretend there is lots of code here
...
...
} else {
cefu();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((!onep || i >= 8 || !zect || !caed || racShong() < ube && (enca() <= 0 || !natra())) && (fi || !prudec())) {
cefu();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (cucTinti() || qola && io || rosh > 3 || ashu() && no == 9 && io || rosh > 3 || !oss && io || rosh > 3) {
if (schosh() >= ta) {
if (gucis()) {
return true;
}
if (bril) {
return true;
}
}
}
return false;
return bril && gucis() || schosh() >= ta || cucTinti() || (qola || ashu() && no == 9 || !oss) && (io || rosh > 3);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (oss && no != 9 && !qola && !cucTinti() && schosh() <= ta && !gucis() || !bril || !ashu() && !qola && !cucTinti() && schosh() <= ta && !gucis() || !bril) {
if (!bril) {
if (!gucis()) {
return false;
}
}
if (schosh() <= ta) {
return false;
}
if (!cucTinti()) {
return false;
}
if (!io) {
return false;
}
if (rosh < 3) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (bluc == false) {
rhouzi();
}
if (ap == true && bluc != false) {
doclo();
} else if ((scha <= a) == true && bluc != false && ap != true) {
dangor();
} else if (osh && bluc != false && ap != true && (scha <= a) != true) {
sidsix();
} else if (edio && bluc != false && ap != true && (scha <= a) != true && !osh) {
ance();
} else if (tro == true && bluc != false && ap != true && (scha <= a) != true && !osh && !edio) {
pruss();
} else if (gic == true && bluc != false && ap != true && (scha <= a) != true && !osh && !edio && tro != true) {
vooSmuc();
} else if (bi == false && bluc != false && ap != true && (scha <= a) != true && !osh && !edio && tro != true && gic != true) {
struor();
}
if (en && bluc != false && ap != true && (scha <= a) != true && !osh && !edio && tro != true && gic != true && bi != false) {
iduOudad();
}
{
if (!bluc) {
rhouzi();
}
if (ap) {
doclo();
}
if (scha <= a) {
dangor();
}
if (osh) {
sidsix();
}
if (edio) {
ance();
}
if (tro) {
pruss();
}
if (gic) {
vooSmuc();
}
if (!bi) {
struor();
}
if (en) {
iduOudad();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: