This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(pse == drue && (foou() || xist() || ec)) && !ol) {
...
...
// Pretend there is lots of code here
...
...
} else {
eshsin();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (ol || pse == drue && (foou() || xist() || ec)) {
eshsin();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (!i && vust() > wo || sicha() < ioad) {
if (iec == 2) {
return true;
}
if (!pec) {
return true;
}
if (seng) {
return true;
}
}
return false;
return seng && !pec && iec == 2 || !i && vust() > wo || sicha() < ioad;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (i && iec != 2 || pec || !seng) {
if (pec || !seng) {
if (iec != 2) {
return false;
}
}
if (vust() < wo) {
return false;
}
}
if (sicha() > ioad) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (pe == true) {
wass();
}
if ((uss == 3) == true && pe != true) {
gadda();
}
if (ge == true && pe != true && (uss == 3) != true) {
aldean();
}
if (zas == true && pe != true && (uss == 3) != true && ge != true) {
parm();
}
if (pe != true && (uss == 3) != true && ge != true && zas != true) {
clol();
}
{
if (pe) {
wass();
}
if (uss == 3) {
gadda();
}
if (ge) {
aldean();
}
if (zas) {
parm();
}
clol();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: