This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (iu || !(we < tetin()) && smoTrae()) {
...
...
// Pretend there is lots of code here
...
...
} else {
oprad();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((!smoTrae() || we < tetin()) && !iu) {
oprad();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (il || giss() < iasto()) {
if (haont()) {
if (cics()) {
return true;
}
}
}
return false;
return cics() || haont() || il || giss() < iasto();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!cics()) {
return false;
}
if (!haont()) {
return false;
}
if (!il) {
return false;
}
if (giss() > iasto()) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (ecos == true) {
troPri();
}
if (ne && ecos != true) {
spli();
} else if (cauc <= 9 && ecos != true && !ne) {
rejec();
}
{
if (ecos) {
troPri();
}
if (ne) {
spli();
}
if (cauc <= 9) {
rejec();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: