This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (inil() < soep() && inic() && an > enpa && ejan && !(e != 6)) {
...
...
// Pretend there is lots of code here
...
...
} else {
pior();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (e != 6 || !ejan || an < enpa || !inic() || inil() > soep()) {
pior();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (ad || mio && !o) {
if (!as) {
return true;
}
if (a) {
return true;
}
if (oxu <= wo) {
return true;
}
}
return false;
return oxu <= wo && a && !as || ad || mio && !o;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!mio && !ad && as || !a || oxu >= wo) {
if (oxu >= wo) {
if (!a) {
if (as) {
return false;
}
}
}
if (!ad) {
return false;
}
if (o) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (il > 6) {
diar();
} else if (ahil == true && il < 6) {
ziant();
}
if (gosm == true && il < 6 && ahil != true) {
korcom();
}
if (i == false && il < 6 && ahil != true && gosm != true) {
chrus();
} else if (il < 6 && ahil != true && gosm != true && i != false) {
draEin();
}
{
if (il > 6) {
diar();
}
if (ahil) {
ziant();
}
if (gosm) {
korcom();
}
if (!i) {
chrus();
}
draEin();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: