This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((!esdi || !flol) && (oun == 9 || !(!vuai || pren())) && (gesoc() && bimial() || enbis() == fech)) {
...
...
// Pretend there is lots of code here
...
...
} else {
hintsa();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (enbis() != fech && (!bimial() || !gesoc()) || (!vuai || pren()) && oun != 9 || flol && esdi) {
hintsa();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (se == or && eiac() && couNoc() == eisFiwac() && ta || facred() && athe && couNoc() == eisFiwac() && ta) {
if (facred() && athe && couNoc() == eisFiwac() && ta) {
if (ta) {
return true;
}
if (couNoc() == eisFiwac()) {
return true;
}
if (eiac()) {
return true;
}
}
if (estrad()) {
return true;
}
}
if (as <= odlan()) {
return true;
}
if (plen() != 0) {
return true;
}
return false;
return plen() != 0 && as <= odlan() && (estrad() || se == or) && (eiac() || facred() && athe) && couNoc() == eisFiwac() && ta;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!athe && !eiac() || !facred() && !eiac() || se != or && !estrad() || as >= odlan() || plen() == 0) {
if (couNoc() != eisFiwac()) {
if (!ta) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (iss != 8) {
pawin();
} else if (aoc < 5 && iss == 8) {
espic();
} else if (urt == true && iss == 8 && aoc > 5) {
issmor();
} else if (i > o && iss == 8 && aoc > 5 && urt != true) {
eeff();
}
if (ul == true && iss == 8 && aoc > 5 && urt != true && i < o) {
adeck();
}
if (lal == false && iss == 8 && aoc > 5 && urt != true && i < o && ul != true) {
eccac();
} else if (uss == true && iss == 8 && aoc > 5 && urt != true && i < o && ul != true && lal != false) {
pedit();
} else if (iss == 8 && aoc > 5 && urt != true && i < o && ul != true && lal != false && uss != true) {
ucron();
}
{
if (iss != 8) {
pawin();
}
if (aoc < 5) {
espic();
}
if (urt) {
issmor();
}
if (i > o) {
eeff();
}
if (ul) {
adeck();
}
if (!lal) {
eccac();
}
if (uss) {
pedit();
}
ucron();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: