This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(thoeda() == 0) || !poc || !reng || skir() || !scal) {
...
...
// Pretend there is lots of code here
...
...
} else {
oinber();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (scal && !skir() && reng && poc && thoeda() == 0) {
oinber();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (aunCoid() && bliOrnsos() || meza() == iss || scron() && bliOrnsos() || meza() == iss) {
if (meza() == iss) {
if (bliOrnsos()) {
return true;
}
}
if (foschi()) {
return true;
}
if (lusmou() <= 3) {
return true;
}
}
return false;
return (lusmou() <= 3 && foschi() || aunCoid() || scron()) && (bliOrnsos() || meza() == iss);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!scron() && !aunCoid() && !foschi() || lusmou() >= 3) {
if (!bliOrnsos()) {
return false;
}
if (meza() != iss) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (e == true) {
frar();
}
if (sme <= 2 && e != true) {
nurCicju();
} else if (i != 7 && e != true && sme >= 2) {
libar();
} else if (aea == true && e != true && sme >= 2 && i == 7) {
drewn();
}
if (vu == false && e != true && sme >= 2 && i == 7 && aea != true) {
ipal();
}
{
if (e) {
frar();
}
if (sme <= 2) {
nurCicju();
}
if (i != 7) {
libar();
}
if (aea) {
drewn();
}
if (!vu) {
ipal();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: