This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (miost() && !de && (kede <= 9 && u || tonist())) {
...
...
// Pretend there is lots of code here
...
...
} else {
ochan();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!tonist() && (!u || kede >= 9) || de || !miost()) {
ochan();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (ad == 5 && eunBessgo()) {
if (eso == 4 && trisea() < 9) {
if (!a) {
if (cecdan()) {
return true;
}
}
}
}
return false;
return cecdan() || !a || eso == 4 && trisea() < 9 || ad == 5 && eunBessgo();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (ad != 5 && trisea() > 9 && a && !cecdan() || eso != 4 && a && !cecdan()) {
if (eso != 4 && a && !cecdan()) {
if (!cecdan()) {
return false;
}
if (a) {
return false;
}
if (trisea() > 9) {
return false;
}
}
if (!eunBessgo()) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (tris == true) {
cioVonci();
} else if (icao == true && tris != true) {
hacArec();
} else if (!ma && tris != true && icao != true) {
crewin();
} else if (ra == 4 && tris != true && icao != true && ma) {
marmau();
}
if (fe > rund && tris != true && icao != true && ma && ra != 4) {
aosCieuc();
}
{
if (tris) {
cioVonci();
}
if (icao) {
hacArec();
}
if (!ma) {
crewin();
}
if (ra == 4) {
marmau();
}
if (fe > rund) {
aosCieuc();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: