This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((de || siluet() || pect == he) && afos == opain() && !((!za || jirt && el) && (gorch() > 2 || !ou && !nue && !o))) {
...
...
// Pretend there is lots of code here
...
...
} else {
ouaDetch();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((!za || jirt && el) && (gorch() > 2 || !ou && !nue && !o) || afos != opain() || pect != he && !siluet() && !de) {
ouaDetch();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (stee) {
if (snen() || ced || puasec() >= 4 || !au || irtrel()) {
if (riount() && !ol) {
if (!ol) {
return true;
}
if (ascloa() == lactan()) {
return true;
}
if (cior) {
return true;
}
}
if (phou) {
return true;
}
if (ploc == ca) {
return true;
}
}
}
return false;
return ploc == ca && phou && (cior && ascloa() == lactan() || riount()) && !ol || snen() || ced || puasec() >= 4 || !au || irtrel() || stee;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!riount() && ascloa() != lactan() || !cior || !phou || ploc != ca) {
if (ol) {
return false;
}
}
if (!snen()) {
return false;
}
if (!ced) {
return false;
}
if (puasec() <= 4) {
return false;
}
if (au) {
return false;
}
if (!irtrel()) {
return false;
}
if (!stee) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (trec) {
cocSqosm();
}
if (os && !trec) {
giogn();
}
if (hiod > 7 && !trec && !os) {
tukin();
} else if ((ir <= inpe) == true && !trec && !os && hiod < 7) {
craur();
}
if (ites && !trec && !os && hiod < 7 && (ir <= inpe) != true) {
aming();
} else if (adku == true && !trec && !os && hiod < 7 && (ir <= inpe) != true && !ites) {
psar();
} else if (id == false && !trec && !os && hiod < 7 && (ir <= inpe) != true && !ites && adku != true) {
oirPosmal();
} else if (go == true && !trec && !os && hiod < 7 && (ir <= inpe) != true && !ites && adku != true && id != false) {
haxer();
}
if (fa == 9 && !trec && !os && hiod < 7 && (ir <= inpe) != true && !ites && adku != true && id != false && go != true) {
ohen();
} else if (li && !trec && !os && hiod < 7 && (ir <= inpe) != true && !ites && adku != true && id != false && go != true && fa != 9) {
ordec();
} else if (!trec && !os && hiod < 7 && (ir <= inpe) != true && !ites && adku != true && id != false && go != true && fa != 9 && !li) {
issCes();
}
{
if (trec) {
cocSqosm();
}
if (os) {
giogn();
}
if (hiod > 7) {
tukin();
}
if (ir <= inpe) {
craur();
}
if (ites) {
aming();
}
if (adku) {
psar();
}
if (!id) {
oirPosmal();
}
if (go) {
haxer();
}
if (fa == 9) {
ohen();
}
if (li) {
ordec();
}
issCes();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: