Booleans and conditionals: Correct Solution


Part 1

This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!

if (!(!eccosm() && !(pubo != zatra())) && (napt() == unk || !stal || shon())) {
    ...
    ...
    // Pretend there is lots of code here
    ...
    ...
} else {
    sipess();
}

Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.

Solution

if (!shon() && stal && napt() != unk || !eccosm() && !(pubo != zatra())) {
    sipess();
} else {
    ...
    ...
    // Pretend there is lots of code here
    ...
    ...
}

Things to double-check in your solution:


Part 2

Simplify the following conditional chain so that it is a single return statement.

if (pral && ounhin() && seso != 2 || chau && seso != 2 || er && seso != 2) {
    if (chau && seso != 2 || er && seso != 2) {
        if (seso != 2) {
            return true;
        }
        if (ounhin()) {
            return true;
        }
    }
    if (numas()) {
        return true;
    }
}
return false;

Solution

return (numas() || pral) && (ounhin() || chau || er) && seso != 2;

Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.

Solution

if (!er && !chau && !ounhin() || !pral && !numas()) {
    if (seso == 2) {
        return false;
    }
}
return true;

Part 3

Simplify the following messy chain of conditionals:

if (e == true) {
    psit();
}
if (spir == 9 && e != true) {
    nanver();
}
if (riod != a && e != true && spir != 9) {
    meroc();
}
if ((ol < ijie) == true && e != true && spir != 9 && riod == a) {
    semo();
} else if (hasm == true && e != true && spir != 9 && riod == a && (ol < ijie) != true) {
    buel();
}

Solution

{
    if (e) {
        psit();
    }
    if (spir == 9) {
        nanver();
    }
    if (riod != a) {
        meroc();
    }
    if (ol < ijie) {
        semo();
    }
    if (hasm) {
        buel();
    }
}

Things to double-check in your solution:


Related puzzles: