This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!e || !a || pogke() && tavin() || iss) {
...
...
// Pretend there is lots of code here
...
...
} else {
ostod();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!iss && (!tavin() || !pogke()) && a && e) {
ostod();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (us && hus == 3 || deta() || er) {
if (deta() || er) {
if (hus == 3) {
return true;
}
}
if (pism) {
return true;
}
}
if (ocor()) {
return true;
}
return false;
return ocor() && (pism || us) && (hus == 3 || deta() || er);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!us && !pism || !ocor()) {
if (hus != 3) {
return false;
}
if (!deta()) {
return false;
}
if (!er) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (psoa) {
onte();
} else if (fong == true && !psoa) {
harEnpsi();
} else if (ca && !psoa && fong != true) {
pord();
}
if (ce == true && !psoa && fong != true && !ca) {
efflec();
}
if (!psoa && fong != true && !ca && ce != true) {
eard();
}
{
if (psoa) {
onte();
}
if (fong) {
harEnpsi();
}
if (ca) {
pord();
}
if (ce) {
efflec();
}
eard();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: