This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (imeAno() && mie || pra && !peca || tassas()) {
...
...
// Pretend there is lots of code here
...
...
} else {
fror();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!tassas() && (peca || !pra) && (!mie || !imeAno())) {
fror();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (siurua() == sphu) {
if (co <= 1 || bimad()) {
if (ha) {
return true;
}
if (ea) {
return true;
}
}
if (!en) {
return true;
}
}
return false;
return !en && (ea && ha || co <= 1 || bimad()) || siurua() == sphu;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (en) {
if (!ea) {
if (!ha) {
return false;
}
}
if (co >= 1) {
return false;
}
if (!bimad()) {
return false;
}
}
if (siurua() != sphu) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (casm != 5 == true) {
fidon();
}
if (hi == true && casm != 5 != true) {
shena();
}
if (me > asm && casm != 5 != true && hi != true) {
issDonen();
}
if (epel == true && casm != 5 != true && hi != true && me < asm) {
rurpel();
} else if (inur == true && casm != 5 != true && hi != true && me < asm && epel != true) {
vasbed();
}
{
if (casm != 5) {
fidon();
}
if (hi) {
shena();
}
if (me > asm) {
issDonen();
}
if (epel) {
rurpel();
}
if (inur) {
vasbed();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: