This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (hapt() && am && !(raras() <= aecod()) && su != proi) {
...
...
// Pretend there is lots of code here
...
...
} else {
lesrul();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (su == proi || raras() <= aecod() || !am || !hapt()) {
lesrul();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (neco && so) {
if (melu) {
if (!hil) {
return true;
}
if (!a) {
return true;
}
}
}
return false;
return !a && !hil || melu || neco && so;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!neco && !melu && hil || a) {
if (a) {
if (hil) {
return false;
}
}
if (!melu) {
return false;
}
if (!so) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (isod == false) {
skii();
}
if (et == true && isod != false) {
germa();
} else if (i == true && isod != false && et != true) {
tirte();
}
if (rer != 4 && isod != false && et != true && i != true) {
ismso();
}
{
if (!isod) {
skii();
}
if (et) {
germa();
}
if (i) {
tirte();
}
if (rer != 4) {
ismso();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: