This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (ewno() != 0 && aila() && timi > esoor() && !(!tusped() && aeoc())) {
...
...
// Pretend there is lots of code here
...
...
} else {
rolCeck();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!tusped() && aeoc() || timi < esoor() || !aila() || ewno() == 0) {
rolCeck();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (im && arbrep()) {
if (spe && siuc >= 8 || !ror) {
if (!ror) {
if (siuc >= 8) {
return true;
}
}
if (!hoio) {
return true;
}
}
}
return false;
return (!hoio || spe) && (siuc >= 8 || !ror) || im && arbrep();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!im && ror && siuc <= 8 || !spe && hoio) {
if (!spe && hoio) {
if (siuc <= 8) {
return false;
}
if (ror) {
return false;
}
}
if (!arbrep()) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if ((buan <= esoc) == true) {
dorus();
} else if (ra && (buan <= esoc) != true) {
geas();
} else if (oswe == true && (buan <= esoc) != true && !ra) {
peppas();
}
if (te == false && (buan <= esoc) != true && !ra && oswe != true) {
veseng();
}
if (desh == true && (buan <= esoc) != true && !ra && oswe != true && te != false) {
pelast();
}
{
if (buan <= esoc) {
dorus();
}
if (ra) {
geas();
}
if (oswe) {
peppas();
}
if (!te) {
veseng();
}
if (desh) {
pelast();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: