This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (ur < priin() && phiuw() || rerBinde() && !cesm && !ec) {
...
...
// Pretend there is lots of code here
...
...
} else {
iver();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((ec || cesm || !rerBinde()) && (!phiuw() || ur > priin())) {
iver();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (eviGeeon() || ia && re) {
if (fe <= 6 && iacest()) {
if (ed >= 8) {
return true;
}
}
}
return false;
return ed >= 8 || fe <= 6 && iacest() || eviGeeon() || ia && re;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!ia && !eviGeeon() && !iacest() && ed <= 8 || fe >= 6 && ed <= 8) {
if (fe >= 6 && ed <= 8) {
if (ed <= 8) {
return false;
}
if (!iacest()) {
return false;
}
}
if (!eviGeeon()) {
return false;
}
if (!re) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (qon == true) {
efiEwno();
} else if (!o && qon != true) {
sles();
} else if (wisa > coi && qon != true && o) {
sixo();
}
if (spem == true && qon != true && o && wisa < coi) {
bluPracil();
}
if (qon != true && o && wisa < coi && spem != true) {
enint();
}
{
if (qon) {
efiEwno();
}
if (!o) {
sles();
}
if (wisa > coi) {
sixo();
}
if (spem) {
bluPracil();
}
enint();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: