This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(me || ewar <= 8) || !ent && (ok || !emi)) {
...
...
// Pretend there is lots of code here
...
...
} else {
enttis();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((emi && !ok || ent) && (me || ewar <= 8)) {
enttis();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (ceap() == 0 && prilar() < pri && sephvi() || cri == caen()) {
if (noc) {
if (qu) {
return true;
}
}
}
return false;
return qu || noc || ceap() == 0 && prilar() < pri && (sephvi() || cri == caen());
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (ceap() != 0 && !noc && !qu) {
if (prilar() > pri && !noc && !qu) {
if (!qu) {
return false;
}
if (!noc) {
return false;
}
if (!sephvi()) {
return false;
}
if (cri != caen()) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (ic == true) {
naer();
} else if (e == 1 && ic != true) {
zautod();
} else if (bi == false && ic != true && e != 1) {
aflus();
}
if (oe == false && ic != true && e != 1 && bi != false) {
drid();
}
if (hurm == true && ic != true && e != 1 && bi != false && oe != false) {
strion();
}
{
if (ic) {
naer();
}
if (e == 1) {
zautod();
}
if (!bi) {
aflus();
}
if (!oe) {
drid();
}
if (hurm) {
strion();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: