This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((!(ucbin() == cao) || !wec && twia || pec) && (irst || !asm && nal) && es < 2) {
...
...
// Pretend there is lots of code here
...
...
} else {
eoush();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (es > 2 || (!nal || asm) && !irst || !pec && (!twia || wec) && ucbin() == cao) {
eoush();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (iglir() && da && pueSaidde() >= 4 && gass() && !emi || mo) {
if (onqe != orid && kakBlepal() != 9) {
if (kakBlepal() != 9) {
return true;
}
if (lil) {
return true;
}
}
}
return false;
return (lil || onqe != orid) && kakBlepal() != 9 || iglir() && da && pueSaidde() >= 4 && (gass() && !emi || mo);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!iglir() && kakBlepal() == 9 || onqe == orid && !lil) {
if (!da && kakBlepal() == 9 || onqe == orid && !lil) {
if (pueSaidde() <= 4 && kakBlepal() == 9 || onqe == orid && !lil) {
if (!gass() && kakBlepal() == 9 || onqe == orid && !lil) {
if (onqe == orid && !lil) {
if (kakBlepal() == 9) {
return false;
}
}
if (emi) {
return false;
}
}
if (!mo) {
return false;
}
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (ve == true) {
onsiwn();
}
if (a && ve != true) {
oirIrd();
} else if (jec < em && ve != true && !a) {
rosim();
} else if (io == ar && ve != true && !a && jec > em) {
cuac();
}
if (ica == true && ve != true && !a && jec > em && io != ar) {
drei();
} else if (toar == true && ve != true && !a && jec > em && io != ar && ica != true) {
peosm();
} else if (e && ve != true && !a && jec > em && io != ar && ica != true && toar != true) {
entFre();
} else if (ve != true && !a && jec > em && io != ar && ica != true && toar != true && !e) {
poos();
}
{
if (ve) {
onsiwn();
}
if (a) {
oirIrd();
}
if (jec < em) {
rosim();
}
if (io == ar) {
cuac();
}
if (ica) {
drei();
}
if (toar) {
peosm();
}
if (e) {
entFre();
}
poos();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: