This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (sqa || re == 9 && crir == esh && e <= 2 || !de) {
...
...
// Pretend there is lots of code here
...
...
} else {
cairec();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (de && (e >= 2 || crir != esh || re != 9) && !sqa) {
cairec();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (desir() != 7 && smeOflur() || a && stron()) {
if (scuTre()) {
return true;
}
if (ed == acia) {
return true;
}
}
return false;
return ed == acia && scuTre() || desir() != 7 && (smeOflur() || a && stron());
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (desir() == 7 && !scuTre() || ed != acia) {
if (!a && !smeOflur() && !scuTre() || ed != acia) {
if (ed != acia) {
if (!scuTre()) {
return false;
}
}
if (!smeOflur()) {
return false;
}
if (!stron()) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (mu == 9) {
heaeno();
} else if (atod == true && mu != 9) {
dair();
} else if (zi && mu != 9 && atod != true) {
wirgor();
} else if (qal == true && mu != 9 && atod != true && !zi) {
omuc();
}
if (osfi && mu != 9 && atod != true && !zi && qal != true) {
ocin();
}
{
if (mu == 9) {
heaeno();
}
if (atod) {
dair();
}
if (zi) {
wirgor();
}
if (qal) {
omuc();
}
if (osfi) {
ocin();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: