This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(!in || mohi || prid) && aenPhiwe() >= 0 && !(jidDac() || roci < edcu)) {
...
...
// Pretend there is lots of code here
...
...
} else {
casmmu();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (jidDac() || roci < edcu || aenPhiwe() <= 0 || !in || mohi || prid) {
casmmu();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (!iu && etgo == hacil() || ie || asm <= 1 || jaglen() != dismed() && etgo == hacil() || ie || asm <= 1) {
if (whi == 4) {
return true;
}
if (nang) {
return true;
}
}
return false;
return nang && whi == 4 || (!iu || jaglen() != dismed()) && (etgo == hacil() || ie || asm <= 1);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (jaglen() == dismed() && iu && whi != 4 || !nang) {
if (!nang) {
if (whi != 4) {
return false;
}
}
if (etgo != hacil()) {
return false;
}
if (!ie) {
return false;
}
if (asm >= 1) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (ste == true) {
riaa();
}
if (esta == true && ste != true) {
tudWengsi();
}
if (!cial && ste != true && esta != true) {
idfan();
}
if (ir && ste != true && esta != true && cial) {
rirpi();
}
if ((di != jalu) == true && ste != true && esta != true && cial && !ir) {
houpar();
}
if (duss == false && ste != true && esta != true && cial && !ir && (di != jalu) != true) {
hual();
}
{
if (ste) {
riaa();
}
if (esta) {
tudWengsi();
}
if (!cial) {
idfan();
}
if (ir) {
rirpi();
}
if (di != jalu) {
houpar();
}
if (!duss) {
hual();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: