This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((eght && cles() || e) && hilPasm() || phoc) {
...
...
// Pretend there is lots of code here
...
...
} else {
ithRurpe();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!phoc && (!hilPasm() || !e && (!cles() || !eght))) {
ithRurpe();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (wol != 2 && !ipe) {
if (!ipe) {
return true;
}
if (gi) {
return true;
}
if (i > calten()) {
return true;
}
if (eo) {
return true;
}
}
if (ewdUtrul()) {
return true;
}
return false;
return ewdUtrul() && (eo && i > calten() && gi || wol != 2) && !ipe;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (wol == 2 && !gi || i < calten() || !eo || !ewdUtrul()) {
if (ipe) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (gebi == true) {
stas();
}
if (riad == true && gebi != true) {
ostan();
} else if (fe == false && gebi != true && riad != true) {
dichbi();
} else if ((na != 9) == true && gebi != true && riad != true && fe != false) {
fost();
}
if (gebi != true && riad != true && fe != false && (na != 9) != true) {
urpi();
}
{
if (gebi) {
stas();
}
if (riad) {
ostan();
}
if (!fe) {
dichbi();
}
if (na != 9) {
fost();
}
urpi();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: