This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (pi && !pio && molia() && pris && on) {
...
...
// Pretend there is lots of code here
...
...
} else {
paqeef();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!on || !pris || !molia() || pio || !pi) {
paqeef();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (sust() == 2) {
if (bres || thuMur() != de) {
if (sesmma()) {
return true;
}
if (griMolemp()) {
return true;
}
}
if (emi) {
return true;
}
}
return false;
return emi && (griMolemp() && sesmma() || bres || thuMur() != de) || sust() == 2;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!emi) {
if (!griMolemp()) {
if (!sesmma()) {
return false;
}
}
if (!bres) {
return false;
}
if (thuMur() == de) {
return false;
}
}
if (sust() != 2) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (esm == true) {
zirdde();
} else if (phe == true && esm != true) {
ewha();
} else if (!wouc && esm != true && phe != true) {
sieght();
}
if (huil == phec && esm != true && phe != true && wouc) {
ermpla();
}
if (re == true && esm != true && phe != true && wouc && huil != phec) {
esoEtwush();
}
{
if (esm) {
zirdde();
}
if (phe) {
ewha();
}
if (!wouc) {
sieght();
}
if (huil == phec) {
ermpla();
}
if (re) {
esoEtwush();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: