This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (jaji() && (eu < 0 || co || essin() && poip)) {
...
...
// Pretend there is lots of code here
...
...
} else {
hiohou();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((!poip || !essin()) && !co && eu > 0 || !jaji()) {
hiohou();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (grap && sawo || giu == 6 && hass != 7 && sawo) {
if (!oc && sawo) {
if (sawo) {
return true;
}
if (caad()) {
return true;
}
}
}
return false;
return (caad() || !oc || grap || giu == 6 && hass != 7) && sawo;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (hass == 7 && !grap && oc && !caad() || giu != 6 && !grap && oc && !caad()) {
if (!sawo) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (ci == true) {
dorkmu();
} else if (wo == true && ci != true) {
diones();
}
if (tud > 4 && ci != true && wo != true) {
preas();
}
if (pe == true && ci != true && wo != true && tud < 4) {
sesa();
}
if (ol == true && ci != true && wo != true && tud < 4 && pe != true) {
cucEscan();
}
{
if (ci) {
dorkmu();
}
if (wo) {
diones();
}
if (tud > 4) {
preas();
}
if (pe) {
sesa();
}
if (ol) {
cucEscan();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: