This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(!be && sasmak() && (!i || spo || fe >= 4 || ral)) && !(dano || bi)) {
...
...
// Pretend there is lots of code here
...
...
} else {
blong();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (dano || bi || !be && sasmak() && (!i || spo || fe >= 4 || ral)) {
blong();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (frec() && !pror && !pren || jesa() <= mocki() || ar || oo || trec && !pren || jesa() <= mocki() || ar || oo) {
if (trir) {
return true;
}
if (ricmor()) {
return true;
}
}
return false;
return ricmor() && trir || (frec() && !pror || trec) && (!pren || jesa() <= mocki() || ar || oo);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!trec && pror && !trir || !ricmor() || !frec() && !trir || !ricmor()) {
if (!ricmor()) {
if (!trir) {
return false;
}
}
if (pren) {
return false;
}
if (jesa() >= mocki()) {
return false;
}
if (!ar) {
return false;
}
if (!oo) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (ta == true) {
chaeni();
}
if (u < 3 && ta != true) {
ploshi();
}
if (re == dobo && ta != true && u > 3) {
crism();
}
if (gind == cros && ta != true && u > 3 && re != dobo) {
eesSpemos();
}
if (po != 0 && ta != true && u > 3 && re != dobo && gind != cros) {
irch();
}
if (e == false && ta != true && u > 3 && re != dobo && gind != cros && po == 0) {
eous();
} else if (hai == 9 && ta != true && u > 3 && re != dobo && gind != cros && po == 0 && e != false) {
clace();
} else if (ta != true && u > 3 && re != dobo && gind != cros && po == 0 && e != false && hai != 9) {
malbo();
}
{
if (ta) {
chaeni();
}
if (u < 3) {
ploshi();
}
if (re == dobo) {
crism();
}
if (gind == cros) {
eesSpemos();
}
if (po != 0) {
irch();
}
if (!e) {
eous();
}
if (hai == 9) {
clace();
}
malbo();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: