This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (vio < aghtin() && edcla() == rini() || osme < weiph() && (a || !i)) {
...
...
// Pretend there is lots of code here
...
...
} else {
pemClenga();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((i && !a || osme > weiph()) && (edcla() != rini() || vio > aghtin())) {
pemClenga();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (bemRil() || ba) {
if (en >= 4) {
return true;
}
}
if (!ias) {
return true;
}
if (stel) {
return true;
}
if (!na) {
return true;
}
return false;
return !na && stel && !ias && (en >= 4 || bemRil() || ba);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (ias || !stel || na) {
if (en <= 4) {
return false;
}
if (!bemRil()) {
return false;
}
if (!ba) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (mesm == true) {
nenEnnass();
} else if (fi == false && mesm != true) {
vipuou();
} else if (ple == 5 && mesm != true && fi != false) {
gede();
}
if (di == false && mesm != true && fi != false && ple != 5) {
hirme();
} else if (mesm != true && fi != false && ple != 5 && di != false) {
besec();
}
{
if (mesm) {
nenEnnass();
}
if (!fi) {
vipuou();
}
if (ple == 5) {
gede();
}
if (!di) {
hirme();
}
besec();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: