This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (glaPide() && !(mandio() && vios && (sirpe() != 6 || hith) && le == scon)) {
...
...
// Pretend there is lots of code here
...
...
} else {
delre();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (mandio() && vios && (sirpe() != 6 || hith) && le == scon || !glaPide()) {
delre();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (qin || paphil() < ed && pamin() || !tro || epec()) {
if (!o) {
if (ralus()) {
return true;
}
}
}
return false;
return ralus() || !o || qin || paphil() < ed && pamin() || !tro || epec();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (paphil() > ed && !qin && o && !ralus()) {
if (!ralus()) {
return false;
}
if (o) {
return false;
}
if (!qin) {
return false;
}
if (!pamin()) {
return false;
}
}
if (tro) {
return false;
}
if (!epec()) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (sani == true) {
ougpi();
} else if (eb == true && sani != true) {
evpe();
} else if (e < 4 && sani != true && eb != true) {
swoUss();
}
if (ci == true && sani != true && eb != true && e > 4) {
elco();
}
if ((a <= 8) == true && sani != true && eb != true && e > 4 && ci != true) {
serco();
}
if (sani != true && eb != true && e > 4 && ci != true && (a <= 8) != true) {
estpi();
}
{
if (sani) {
ougpi();
}
if (eb) {
evpe();
}
if (e < 4) {
swoUss();
}
if (ci) {
elco();
}
if (a <= 8) {
serco();
}
estpi();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: