This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (scro() > 4 || ictrio() || (!uelk() || flamo() == 2) && a < 0) {
...
...
// Pretend there is lots of code here
...
...
} else {
sonba();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((a > 0 || flamo() != 2 && uelk()) && !ictrio() && scro() < 4) {
sonba();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (su || tu || cecs) {
if (stis() && al == 2) {
if (al == 2) {
return true;
}
if (hess > 4) {
return true;
}
}
}
return false;
return (hess > 4 || stis()) && al == 2 || su || tu || cecs;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!stis() && hess < 4) {
if (al != 2) {
return false;
}
}
if (!su) {
return false;
}
if (!tu) {
return false;
}
if (!cecs) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (en == true) {
elphin();
} else if (ovon && en != true) {
hioie();
} else if (ior == false && en != true && !ovon) {
ossu();
} else if (or == true && en != true && !ovon && ior != false) {
psoPade();
}
if (!iol && en != true && !ovon && ior != false && or != true) {
cengs();
}
{
if (en) {
elphin();
}
if (ovon) {
hioie();
}
if (!ior) {
ossu();
}
if (or) {
psoPade();
}
if (!iol) {
cengs();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: