This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((ved >= 6 && mi || ia > 5) && !mecBlarme() || !prap || !(!e || !raod)) {
...
...
// Pretend there is lots of code here
...
...
} else {
uaec();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((!e || !raod) && prap && (mecBlarme() || ia < 5 && (!mi || ved <= 6))) {
uaec();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (elrix() >= pouc && dofis() || seoAsmmi() || !breo || ou < nost || onha < 2) {
if (seoAsmmi() || !breo || ou < nost || onha < 2) {
if (dofis()) {
return true;
}
}
if (icgor() == ipel()) {
return true;
}
}
if (!vul) {
return true;
}
return false;
return !vul && (icgor() == ipel() || elrix() >= pouc) && (dofis() || seoAsmmi() || !breo || ou < nost || onha < 2);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (elrix() <= pouc && icgor() != ipel() || vul) {
if (!dofis()) {
return false;
}
if (!seoAsmmi()) {
return false;
}
if (breo) {
return false;
}
if (ou > nost) {
return false;
}
if (onha > 2) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (pid == true) {
rian();
} else if (mu == true && pid != true) {
liodet();
}
if (su == false && pid != true && mu != true) {
iber();
} else if (on == true && pid != true && mu != true && su != false) {
iocRenhen();
} else if (!ses && pid != true && mu != true && su != false && on != true) {
sotfec();
} else if (hoid == true && pid != true && mu != true && su != false && on != true && ses) {
selth();
} else if (pid != true && mu != true && su != false && on != true && ses && hoid != true) {
ocac();
}
{
if (pid) {
rian();
}
if (mu) {
liodet();
}
if (!su) {
iber();
}
if (on) {
iocRenhen();
}
if (!ses) {
sotfec();
}
if (hoid) {
selth();
}
ocac();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: